Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add before_emit callback for metrics #2258

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

sl0thentr0py
Copy link
Member

part of #2246

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Merging #2258 (da14eaf) into neel/metrics/span-aggregator (0df891d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           neel/metrics/span-aggregator    #2258      +/-   ##
================================================================
+ Coverage                         97.54%   97.57%   +0.02%     
================================================================
  Files                               112      112              
  Lines                              4108     4116       +8     
================================================================
+ Hits                               4007     4016       +9     
+ Misses                              101      100       -1     
Components Coverage Δ
sentry-ruby 98.28% <100.00%> (+0.03%) ⬆️
sentry-rails 95.05% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 90.76% <ø> (ø)
sentry-delayed_job 95.60% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.79% <ø> (-0.02%) ⬇️
sentry-ruby/lib/sentry/metrics/aggregator.rb 99.07% <100.00%> (+0.02%) ⬆️
sentry-ruby/lib/sentry/metrics/configuration.rb 100.00% <100.00%> (ø)
...-ruby/lib/sentry/utils/argument_checking_helper.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/metrics/before-emit branch from bcd1c02 to 39b339a Compare March 8, 2024 14:08
@sl0thentr0py sl0thentr0py mentioned this pull request Mar 8, 2024
@sl0thentr0py sl0thentr0py requested a review from st0012 March 8, 2024 14:08
@sl0thentr0py sl0thentr0py changed the title Add config.metrics.before_emit callback Add before_emit callback Mar 8, 2024
@sl0thentr0py sl0thentr0py changed the title Add before_emit callback Add before_emit callback for metrics Mar 8, 2024
@sl0thentr0py sl0thentr0py force-pushed the neel/metrics/span-aggregator branch from 2a4ea74 to 116318b Compare March 12, 2024 13:04
@sl0thentr0py sl0thentr0py force-pushed the neel/metrics/before-emit branch from 39b339a to da14eaf Compare March 12, 2024 13:15
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good from my side

@sl0thentr0py sl0thentr0py merged commit 9a7abaf into neel/metrics/span-aggregator Mar 12, 2024
121 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/metrics/before-emit branch March 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants