Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Rake patch #2214

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Remove unnecessary Rake patch #2214

merged 1 commit into from
Jan 2, 2024

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jan 1, 2024

The patch was a leftover from #1617 and can be removed.

Closes #2196

#skip-changelog

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Merging #2214 (166041e) into master (babdd55) will increase coverage by 30.96%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2214       +/-   ##
===========================================
+ Coverage   66.48%   97.45%   +30.96%     
===========================================
  Files         100      102        +2     
  Lines        3742     3808       +66     
===========================================
+ Hits         2488     3711     +1223     
+ Misses       1254       97     -1157     
Components Coverage Δ
sentry-ruby 98.14% <ø> (+42.23%) ⬆️
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 93.65% <ø> (+1.58%) ⬆️
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/rake.rb 64.28% <ø> (-0.72%) ⬇️

... and 56 files with indirect coverage changes

@st0012 st0012 merged commit 1fe52d1 into master Jan 2, 2024
122 of 123 checks passed
@st0012 st0012 deleted the fix-#2196 branch January 2, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about the override to Rake::Task#execute
2 participants