Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentry-delayed_job: respect custom max_attempts #2177

Merged

Conversation

natikgadzhi
Copy link
Contributor

@natikgadzhi natikgadzhi commented Nov 23, 2023

Summary

/cc @sl0thentr0py are you tired of me yet?

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #2177 (f991b4b) into master (7793e97) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
+ Coverage   97.30%   97.33%   +0.02%     
==========================================
  Files          99       99              
  Lines        3680     3681       +1     
==========================================
+ Hits         3581     3583       +2     
+ Misses         99       98       -1     
Components Coverage Δ
sentry-ruby 98.02% <ø> (ø)
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 94.50% <ø> (ø)
sentry-resque 93.65% <ø> (+1.58%) ⬆️
sentry-delayed_job 94.44% <100.00%> (+0.07%) ⬆️
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
...entry-delayed_job/lib/sentry/delayed_job/plugin.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog entry for this?

sentry-delayed_job/spec/sentry/delayed_job_spec.rb Outdated Show resolved Hide resolved
@st0012 st0012 added the bug fix label Nov 23, 2023
@natikgadzhi
Copy link
Contributor Author

@st0012 yep, I've added it and didn't push it up 🤦🏼. Fixed.

@st0012 st0012 merged commit 19251ea into getsentry:master Nov 23, 2023
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delayed job plugin misses errors from jobs with custom max_attempts
2 participants