Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) crons: require sidekiq-cron early #2173

Merged
merged 2 commits into from
Nov 23, 2023

Don't pass options arg to Sidekiq::Cron::Job.load_from_hash!

4bd493a
Select commit
Loading
Failed to load commit list.
Merged

(fix) crons: require sidekiq-cron early #2173

Don't pass options arg to Sidekiq::Cron::Job.load_from_hash!
4bd493a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 22, 2023 in 0s

97.34% (-0.06%) compared to c7c8e5b

View this Pull Request on Codecov

97.34% (-0.06%) compared to c7c8e5b

Details

Codecov Report

Merging #2173 (4bd493a) into master (c7c8e5b) will decrease coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2173      +/-   ##
==========================================
- Coverage   97.40%   97.34%   -0.06%     
==========================================
  Files          98       98              
  Lines        3655     3656       +1     
==========================================
- Hits         3560     3559       -1     
- Misses         95       97       +2
Components Coverage Δ
sentry-ruby 98.02% <ø> (ø)
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 94.93% <50.00%> (-0.61%) ⬇️
sentry-resque 92.06% <ø> (-1.59%) ⬇️
sentry-delayed_job 94.36% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-sidekiq/lib/sentry/sidekiq/cron/job.rb 92.85% <50.00%> (-7.15%) ⬇️

... and 1 file with indirect coverage changes

View more details on Codecov