Fix exception event sending failed #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujideveloper
force-pushed
the
bugfix/exception-sending-failed-illegal-malformed-utf-8
branch
from
cbb3869 to
8dec063
Compare
yujideveloper
force-pushed
the
bugfix/exception-sending-failed-illegal-malformed-utf-8
branch
from
8dec063 to
2992cf9
Compare
|
Sorry for the delay. I'm not sure why there's no triggerable CI runs on this PR. I also found a few expected failures when pulled the branch locally. Would you mind rebasing it against |
yujideveloper
force-pushed
the
bugfix/exception-sending-failed-illegal-malformed-utf-8
branch
from
2992cf9 to
6d16b25
Compare
|
@st0012 |
Codecov ReportAttention:
... and 24 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
yujideveloper
force-pushed
the
bugfix/exception-sending-failed-illegal-malformed-utf-8
branch
3 times, most recently
from
f73015d to
96d8205
Compare
|
I resolved confilict and fixed failing tests. |
yujideveloper
force-pushed
the
bugfix/exception-sending-failed-illegal-malformed-utf-8
branch
from
96d8205 to
bf8c61d
Compare
|
I missed a syntax error in Ruby 2.4 ... |
yujideveloper
force-pushed
the
bugfix/exception-sending-failed-illegal-malformed-utf-8
branch
from
bf8c61d to
f000758
Compare
|
I improved test coverage. |
This fixes `Event sending failed: source sequence is illegal/malformed utf-8`.
yujideveloper
force-pushed
the
bugfix/exception-sending-failed-illegal-malformed-utf-8
branch
from
f000758 to
b48724b
Compare
|
I resolved confilict. |
|
The tests failing are caused by latest Rails changes. I will fix them in a separate PR. |
yujideveloper
deleted the
bugfix/exception-sending-failed-illegal-malformed-utf-8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2082