Fixed Ruby version checks for proxy conf

getsentry · Nov 23, 2023 · a706d3f · a706d3f
1 parent d97e181
commit a706d3f
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/sentry-ruby/spec/sentry/transport/http_transport_spec.rb b/sentry-ruby/spec/sentry/transport/http_transport_spec.rb
@@ -135,9 +135,12 @@
 
         stub_request(fake_response) do |_, http_obj|
           expect(http_obj.proxy_address).to eq("example.com")
-          expect(http_obj.proxy_user).to eq("stan")
-          expect(http_obj.proxy_pass).to eq("foobar")
           expect(http_obj.proxy_port).to eq(8080)
+
+          if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.5")
+            expect(http_obj.proxy_user).to eq("stan")
+            expect(http_obj.proxy_pass).to eq("foobar")
+          end
         end
 
         subject.send_data(data)
@@ -152,7 +155,7 @@
       stub_request(fake_response) do |_, http_obj|
         expect(http_obj.read_timeout).to eq(10)
 
-        if RUBY_VERSION >= "2.6"
+        if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.6")
           expect(http_obj.write_timeout).to eq(10)
         end
       end