-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Java and Android #41
Conversation
972a1b8
to
215b268
Compare
"version": "4.1.0", | ||
"package_url": "https://search.maven.org/artifact/io.sentry/sentry-apache-http-client-5", | ||
"repo_url": "https://github.com/getsentry/sentry-java", | ||
"main_docs_url": "https://docs.sentry.io/platforms/java/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we get a dedicated page, we just point to the main Java docs.
Today it's under /platform/java/transport
but I'm not sure that'll be a stable link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep the java root page, agreed
"version": "1.7.36", | ||
"package_url": "https://search.maven.org/artifact/io.sentry/sentry-android-gradle-plugin", | ||
"repo_url": "https://github.com/getsentry/sentry-android-gradle-plugin", | ||
"main_docs_url": "https://docs.sentry.io/platforms/android" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more specific link would be https://docs.sentry.io/platforms/android/proguard/
But again not sure this is stable/correct given we might move this around, or do more with the plugin. So the top level android sounds better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'd make sense to have its own "Plugin page" that could be under multiple platforms cus the plugin is used by Flutter/RN/Cordova etc, but yeah lets not block this now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep the android root page, agreed
… into feat/add-java-android
[*] | ||
indent_style = space | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true | ||
|
||
[*.md] | ||
trim_trailing_whitespace = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted the editor to clear the spaces at the end of the lines (but not on markdown) so I added it.
Also the empty line at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure about md parts of editorconfig but if somebody finds it annoying we can readjust
I don't use it anyway so idc
Thanks for merging. vscode picks up the config, those settings help out when doing the files by hand at first |
Depends on:
Timber: getsentry/sentry-docs#3088 (unless we just point to
/platform/android
for now.servlet: getsentry/sentry-docs#3087 (unless we got with
/platform/java
until added)Resolves #34
/cc @maciejwalkowiak
See also:
getsentry/sentry-android-gradle-plugin#42
getsentry/sentry-java#1249