Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Java and Android #41

Merged
merged 6 commits into from
Feb 17, 2021
Merged

feat: add Java and Android #41

merged 6 commits into from
Feb 17, 2021

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Feb 13, 2021

Depends on:

Timber: getsentry/sentry-docs#3088 (unless we just point to /platform/android for now.
servlet: getsentry/sentry-docs#3087 (unless we got with /platform/java until added)

Resolves #34

/cc @maciejwalkowiak

See also:

getsentry/sentry-android-gradle-plugin#42
getsentry/sentry-java#1249

packages/maven/sentry-servlet/4.1.0.json Outdated Show resolved Hide resolved
packages/maven/sentry-jul/4.1.0.json Show resolved Hide resolved
"version": "4.1.0",
"package_url": "https://search.maven.org/artifact/io.sentry/sentry-apache-http-client-5",
"repo_url": "https://github.com/getsentry/sentry-java",
"main_docs_url": "https://docs.sentry.io/platforms/java/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we get a dedicated page, we just point to the main Java docs.

Today it's under /platform/java/transport but I'm not sure that'll be a stable link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep the java root page, agreed

packages/maven/sentry-android-timber/4.1.0.json Outdated Show resolved Hide resolved
"version": "1.7.36",
"package_url": "https://search.maven.org/artifact/io.sentry/sentry-android-gradle-plugin",
"repo_url": "https://github.com/getsentry/sentry-android-gradle-plugin",
"main_docs_url": "https://docs.sentry.io/platforms/android"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more specific link would be https://docs.sentry.io/platforms/android/proguard/

But again not sure this is stable/correct given we might move this around, or do more with the plugin. So the top level android sounds better.

Copy link
Contributor

@marandaneto marandaneto Feb 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd make sense to have its own "Plugin page" that could be under multiple platforms cus the plugin is used by Flutter/RN/Cordova etc, but yeah lets not block this now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep the android root page, agreed

@bruno-garcia bruno-garcia requested a review from HazAT February 14, 2021 00:32
Comment on lines +1 to +7
[*]
indent_style = space
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
trim_trailing_whitespace = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong add?

Copy link
Member Author

@bruno-garcia bruno-garcia Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted the editor to clear the spaces at the end of the lines (but not on markdown) so I added it.

Also the empty line at the end

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about md parts of editorconfig but if somebody finds it annoying we can readjust

I don't use it anyway so idc

@untitaker untitaker merged commit 7289e34 into master Feb 17, 2021
@untitaker untitaker deleted the feat/add-java-android branch February 17, 2021 10:22
@bruno-garcia
Copy link
Member Author

Thanks for merging.

vscode picks up the config, those settings help out when doing the files by hand at first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Java, Android
3 participants