Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds utility class for converting JsonObject to WritableMap #4479

Merged

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jan 22, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Implements a utility class RNSentryJsonConverter converting a JsonObject to a WritableMap

💡 Motivation and Context

Part of #3608

💚 How did you test it?

Unit tests

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis changed the title Convert json object to writable map Adds utility class for converting JsonObject to WritableMap Jan 22, 2025
@antonis antonis marked this pull request as ready for review January 22, 2025 18:18
Copy link
Contributor

github-actions bot commented Jan 22, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.00 ms 429.06 ms 47.06 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
208f4af+dirty 346.93 ms 402.77 ms 55.84 ms
555070f+dirty 388.25 ms 424.44 ms 36.19 ms

App size

Revision Plain With Sentry Diff
208f4af+dirty 7.15 MiB 8.38 MiB 1.23 MiB
555070f+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: antonis/convertJsonObjectToWritableMap

Startup times

Revision Plain With Sentry Diff
e29f0bc+dirty 355.77 ms 420.68 ms 64.91 ms

App size

Revision Plain With Sentry Diff
e29f0bc+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Copy link
Contributor

github-actions bot commented Jan 22, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.14 ms 1223.57 ms 5.43 ms
Size 2.63 MiB 3.69 MiB 1.05 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
555070f+dirty 1213.59 ms 1217.79 ms 4.20 ms
208f4af+dirty 1209.44 ms 1217.13 ms 7.70 ms

App size

Revision Plain With Sentry Diff
555070f+dirty 2.63 MiB 3.69 MiB 1.05 MiB
208f4af+dirty 2.63 MiB 3.69 MiB 1.05 MiB

Previous results on branch: antonis/convertJsonObjectToWritableMap

Startup times

Revision Plain With Sentry Diff
e29f0bc+dirty 1225.39 ms 1236.28 ms 10.89 ms

App size

Revision Plain With Sentry Diff
e29f0bc+dirty 2.63 MiB 3.69 MiB 1.05 MiB

Copy link
Contributor

github-actions bot commented Jan 22, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.27 ms 1233.63 ms 10.35 ms
Size 3.19 MiB 4.25 MiB 1.07 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
555070f+dirty 1223.61 ms 1227.57 ms 3.96 ms
208f4af+dirty 1213.08 ms 1223.82 ms 10.73 ms

App size

Revision Plain With Sentry Diff
555070f+dirty 3.19 MiB 4.25 MiB 1.06 MiB
208f4af+dirty 3.19 MiB 4.25 MiB 1.06 MiB

Previous results on branch: antonis/convertJsonObjectToWritableMap

Startup times

Revision Plain With Sentry Diff
e29f0bc+dirty 1226.82 ms 1226.45 ms -0.37 ms

App size

Revision Plain With Sentry Diff
e29f0bc+dirty 3.19 MiB 4.25 MiB 1.07 MiB

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 484.87 ms 501.91 ms 17.04 ms
Size 17.75 MiB 20.11 MiB 2.37 MiB

Baseline results on branch: capture-app-start-errors

Startup times

Revision Plain With Sentry Diff
555070f 438.67 ms 428.30 ms -10.37 ms
208f4af 439.23 ms 427.31 ms -11.92 ms

App size

Revision Plain With Sentry Diff
555070f 17.75 MiB 20.11 MiB 2.37 MiB
208f4af 17.75 MiB 20.11 MiB 2.37 MiB

Previous results on branch: antonis/convertJsonObjectToWritableMap

Startup times

Revision Plain With Sentry Diff
e29f0bc 408.38 ms 399.68 ms -8.69 ms

App size

Revision Plain With Sentry Diff
e29f0bc 17.75 MiB 20.11 MiB 2.37 MiB

Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you, this is nice and simple!

@krystofwoldrich
Copy link
Member

Merging this means,

can be closed and

@antonis antonis merged commit 1e5dbde into capture-app-start-errors Jan 23, 2025
66 checks passed
@antonis antonis deleted the antonis/convertJsonObjectToWritableMap branch January 23, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants