feat: Read sentry.options.json during cocoa init
#4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Android (new) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 555070f+dirty | 1213.59 ms | 1217.79 ms | 4.20 ms |
| 208f4af+dirty | 1209.44 ms | 1217.13 ms | 7.70 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 555070f+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| 208f4af+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
Previous results on branch: kw-add-read-ios-options-file
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4682761+dirty | 1219.41 ms | 1228.23 ms | 8.82 ms |
| eda229b+dirty | 1224.98 ms | 1225.46 ms | 0.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4682761+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| eda229b+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 555070f+dirty | 1223.61 ms | 1227.57 ms | 3.96 ms |
| 208f4af+dirty | 1213.08 ms | 1223.82 ms | 10.73 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 555070f+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 208f4af+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
Previous results on branch: kw-add-read-ios-options-file
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4682761+dirty | 1221.30 ms | 1225.33 ms | 4.03 ms |
| eda229b+dirty | 1227.17 ms | 1235.08 ms | 7.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4682761+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
| eda229b+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
…to kw-add-read-ios-options-file
krystofwoldrich
requested review from
philipphofmann,
brustolin and
philprime
Android (legacy) Performance metrics 🚀
|
7 tasks
krystofwoldrich
requested review from
lucas-zimerman and
antonis
as code owners
antonis
approved these changes
Jan 22, 2025
Base automatically changed from
kw-add-react-native-ios-manual-init
to
capture-app-start-errors
January 22, 2025 13:24
…w-add-read-ios-options-file
…to kw-add-read-ios-options-file
krystofwoldrich
merged commit 7850677
into
capture-app-start-errors
65 of 66 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
⛓️ PR Chain
startWithConfigureOptionsfor Apple platforms #4444sentry.options.jsonduring cocoa init #4447📜 Description
This PR adds
[RNSentrySDK start]function (exported byRNSentry/RNSentry.h) which allows users to initialize Sentry Cocoa in RN applications without any additional params because the options are loaded fromsentry.options.json.This PR adds automatic copy of
sentry.options.jsonresource from root of the RN project. This works as long as users setupedsentry-xcode.shon theirBundle RNbuild phase.💡 Motivation and Context
💚 How did you test it?
Only in Sample app for now, tests will follow.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps