ref(android): Extracts Android native initialization to standalone structures #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0b81196 | 501.00 ms | 506.41 ms | 5.41 ms |
| b2a0c05 | 439.75 ms | 449.83 ms | 10.08 ms |
| c4bd9bf | 428.13 ms | 418.76 ms | -9.37 ms |
| 9f9c2c7 | 446.59 ms | 448.52 ms | 1.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0b81196 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| b2a0c05 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| c4bd9bf | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 9f9c2c7 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4bd9bf+dirty | 1212.41 ms | 1219.76 ms | 7.35 ms |
| b2a0c05+dirty | 1223.98 ms | 1231.33 ms | 7.35 ms |
| 0b81196+dirty | 1239.04 ms | 1239.41 ms | 0.37 ms |
| 9f9c2c7+dirty | 1226.22 ms | 1227.06 ms | 0.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4bd9bf+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| b2a0c05+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| 0b81196+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 9f9c2c7+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4bd9bf+dirty | 1234.83 ms | 1242.81 ms | 7.98 ms |
| b2a0c05+dirty | 1224.71 ms | 1227.85 ms | 3.14 ms |
| 0b81196+dirty | 1228.43 ms | 1234.00 ms | 5.57 ms |
| 9f9c2c7+dirty | 1239.08 ms | 1232.19 ms | -6.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4bd9bf+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| b2a0c05+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 0b81196+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 9f9c2c7+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4bd9bf+dirty | 369.98 ms | 389.00 ms | 19.02 ms |
| b2a0c05+dirty | 391.85 ms | 429.19 ms | 37.34 ms |
| 0b81196+dirty | 402.70 ms | 452.38 ms | 49.68 ms |
| 9f9c2c7+dirty | 412.58 ms | 457.55 ms | 44.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4bd9bf+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| b2a0c05+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 0b81196+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 9f9c2c7+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
10 tasks
lucas-zimerman
approved these changes
Jan 16, 2025
packages/core/android/src/main/java/io/sentry/react/RNSentryStart.java
Outdated
Show resolved
Hide resolved
krystofwoldrich
changed the base branch from
main
to
capture-app-start-errors
This was referenced Jan 21, 2025
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Extracts Android native initialization to standalone structures
⛓️ PR Chain
💡 Motivation and Context
Part of #3608
💚 How did you test it?
Manual, CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps