chore(ci): Pin the CI Environment to Ubuntu 22.04 for metrics android #4424

antonis · 2025-01-08T12:12:46Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Pins the CI Environment to Ubuntu 22.04 for metrics Android to avoid the CI failure as described in #4418 (comment)

💡 Motivation and Context

Fix #4418

💚 How did you test it?

CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Upgrade the performance test apps (TestAppPlain/TestAppSentry) on the latest RN version so that they run with latest Ubuntu.

#skip-changelog

github-actions · 2025-01-08T12:23:29Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	475.45 ms	463.24 ms	-12.21 ms
Size	17.75 MiB	20.11 MiB	2.36 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`3853f43`	329.68 ms	346.32 ms	16.64 ms
`4297324`	536.61 ms	542.48 ms	5.87 ms
`e73d82f`	475.82 ms	506.55 ms	30.73 ms
`27ef4ee`	317.40 ms	321.70 ms	4.30 ms
`fe13591`	478.92 ms	480.84 ms	1.92 ms
`484813b`	434.55 ms	452.31 ms	17.75 ms
`8ab11b6`	462.10 ms	450.40 ms	-11.70 ms
`5a22220`	412.38 ms	447.35 ms	34.97 ms
`83f6f6c`	418.83 ms	410.94 ms	-7.89 ms
`f06c879`	408.41 ms	424.54 ms	16.13 ms

App size

Revision	Plain	With Sentry	Diff
`3853f43`	17.73 MiB	19.81 MiB	2.08 MiB
`4297324`	17.74 MiB	20.08 MiB	2.34 MiB
`e73d82f`	17.73 MiB	20.07 MiB	2.33 MiB
`27ef4ee`	17.73 MiB	19.82 MiB	2.08 MiB
`fe13591`	17.74 MiB	20.07 MiB	2.34 MiB
`484813b`	17.73 MiB	20.07 MiB	2.33 MiB
`8ab11b6`	17.74 MiB	20.09 MiB	2.35 MiB
`5a22220`	17.73 MiB	19.93 MiB	2.20 MiB
`83f6f6c`	17.74 MiB	20.09 MiB	2.35 MiB
`f06c879`	17.73 MiB	19.85 MiB	2.12 MiB

github-actions · 2025-01-08T12:34:25Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	394.67 ms	398.71 ms	4.04 ms
Size	7.15 MiB	8.38 MiB	1.23 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8fe7c9d`+dirty	363.91 ms	429.93 ms	66.03 ms
`83f6f6c`+dirty	442.82 ms	487.48 ms	44.66 ms
`f06c879`+dirty	361.27 ms	407.88 ms	46.61 ms
`d16beca`+dirty	389.49 ms	423.86 ms	34.37 ms
`b95b8af`+dirty	392.94 ms	428.00 ms	35.06 ms
`ac41368`+dirty	395.91 ms	451.17 ms	55.26 ms
`9dabcce`+dirty	359.66 ms	430.73 ms	71.08 ms
`c639edf`+dirty	363.39 ms	414.78 ms	51.39 ms
`79976dd`+dirty	373.25 ms	404.64 ms	31.39 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms

App size

Revision	Plain	With Sentry	Diff
`8fe7c9d`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`83f6f6c`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`f06c879`+dirty	7.15 MiB	8.12 MiB	997.78 KiB
`d16beca`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`b95b8af`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`ac41368`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`9dabcce`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`c639edf`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`79976dd`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB

github-actions · 2025-01-08T12:37:36Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1237.08 ms	1241.98 ms	4.90 ms
Size	3.19 MiB	4.25 MiB	1.06 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5bc97b`+dirty	1229.17 ms	1227.64 ms	-1.54 ms
`205982c`+dirty	1228.06 ms	1237.72 ms	9.66 ms
`57448c5`+dirty	1244.65 ms	1249.20 ms	4.55 ms
`b1e8712`+dirty	1284.11 ms	1297.82 ms	13.71 ms
`946a600`+dirty	1236.12 ms	1234.94 ms	-1.18 ms
`b8ff156`+dirty	1238.92 ms	1239.57 ms	0.66 ms
`0ebca77`+dirty	1209.30 ms	1220.33 ms	11.03 ms
`9385d74`+dirty	1239.51 ms	1245.88 ms	6.37 ms
`9dabcce`+dirty	1247.71 ms	1239.18 ms	-8.53 ms
`690220d`+dirty	1227.45 ms	1221.67 ms	-5.78 ms

App size

Revision	Plain	With Sentry	Diff
`e5bc97b`+dirty	2.92 MiB	3.66 MiB	758.40 KiB
`205982c`+dirty	2.92 MiB	3.67 MiB	772.63 KiB
`57448c5`+dirty	2.92 MiB	3.66 MiB	756.65 KiB
`b1e8712`+dirty	2.92 MiB	3.40 MiB	494.15 KiB
`946a600`+dirty	2.92 MiB	3.67 MiB	772.40 KiB
`b8ff156`+dirty	2.92 MiB	3.67 MiB	772.38 KiB
`0ebca77`+dirty	2.92 MiB	3.61 MiB	705.12 KiB
`9385d74`+dirty	2.92 MiB	3.67 MiB	772.40 KiB
`9dabcce`+dirty	2.92 MiB	3.67 MiB	770.02 KiB
`690220d`+dirty	2.92 MiB	3.66 MiB	758.77 KiB

github-actions · 2025-01-08T12:37:47Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1209.22 ms	1219.58 ms	10.36 ms
Size	2.63 MiB	3.68 MiB	1.05 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5bc97b`+dirty	1230.63 ms	1234.83 ms	4.20 ms
`205982c`+dirty	1226.83 ms	1234.36 ms	7.53 ms
`57448c5`+dirty	1228.73 ms	1235.90 ms	7.16 ms
`b1e8712`+dirty	1256.02 ms	1265.14 ms	9.12 ms
`946a600`+dirty	1238.20 ms	1236.85 ms	-1.35 ms
`b8ff156`+dirty	1236.51 ms	1234.53 ms	-1.98 ms
`0ebca77`+dirty	1220.75 ms	1222.81 ms	2.06 ms
`9385d74`+dirty	1215.18 ms	1216.43 ms	1.25 ms
`9dabcce`+dirty	1231.39 ms	1238.02 ms	6.63 ms
`690220d`+dirty	1228.27 ms	1233.55 ms	5.29 ms

App size

Revision	Plain	With Sentry	Diff
`e5bc97b`+dirty	2.36 MiB	3.10 MiB	753.14 KiB
`205982c`+dirty	2.36 MiB	3.11 MiB	760.04 KiB
`57448c5`+dirty	2.36 MiB	3.10 MiB	752.34 KiB
`b1e8712`+dirty	2.36 MiB	2.84 MiB	488.84 KiB
`946a600`+dirty	2.36 MiB	3.10 MiB	759.74 KiB
`b8ff156`+dirty	2.36 MiB	3.11 MiB	759.80 KiB
`0ebca77`+dirty	2.36 MiB	3.04 MiB	698.33 KiB
`9385d74`+dirty	2.36 MiB	3.10 MiB	759.78 KiB
`9dabcce`+dirty	2.36 MiB	3.10 MiB	757.52 KiB
`690220d`+dirty	2.36 MiB	3.10 MiB	753.57 KiB

.github/workflows/e2e.yml

lucas-zimerman

just a suggestion but other than that LGTM!

Co-authored-by: LucasZF <[email protected]>

Pin the CI Environment to Ubuntu 22.04

d8f32b4

antonis changed the title ~~ci: Pin the CI Environment to Ubuntu 22.04~~ ci: Pin the CI Environment to Ubuntu 22.04 for metrics android Jan 8, 2025

antonis changed the title ~~ci: Pin the CI Environment to Ubuntu 22.04 for metrics android~~ ci(test): Pin the CI Environment to Ubuntu 22.04 for metrics android Jan 8, 2025

antonis mentioned this pull request Jan 8, 2025

ci: metrics (new, android) fails #4418

Closed

antonis marked this pull request as ready for review January 8, 2025 12:38

antonis requested review from krystofwoldrich and lucas-zimerman as code owners January 8, 2025 12:38

lucas-zimerman reviewed Jan 8, 2025

View reviewed changes

.github/workflows/e2e.yml Show resolved Hide resolved

lucas-zimerman approved these changes Jan 8, 2025

View reviewed changes

Document why we pin the ubuntu version

9fb1767

Co-authored-by: LucasZF <[email protected]>

antonis changed the title ~~ci(test): Pin the CI Environment to Ubuntu 22.04 for metrics android~~ chore(ci): Pin the CI Environment to Ubuntu 22.04 for metrics android Jan 8, 2025

antonis mentioned this pull request Jan 8, 2025

Upgrade performance test apps on the latest RN version #4426

Open

antonis merged commit 5f03ae9 into main Jan 8, 2025
71 of 72 checks passed

antonis deleted the antonis/ci-metrics-ubuntu-version branch January 8, 2025 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): Pin the CI Environment to Ubuntu 22.04 for metrics android #4424

chore(ci): Pin the CI Environment to Ubuntu 22.04 for metrics android #4424

antonis commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 8, 2025 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 8, 2025

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 8, 2025 •

edited

Loading

Baseline results on branch: main

Startup times

App size

lucas-zimerman left a comment

chore(ci): Pin the CI Environment to Ubuntu 22.04 for metrics android #4424

chore(ci): Pin the CI Environment to Ubuntu 22.04 for metrics android #4424

Conversation

antonis commented Jan 8, 2025 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Jan 8, 2025 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 8, 2025 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 8, 2025

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 8, 2025 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

lucas-zimerman left a comment

Choose a reason for hiding this comment

antonis commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading