Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): Fixes RNSentryAndroidTester compatibility with AS Ladybug #4409

Merged
merged 4 commits into from
Jan 10, 2025
Merged

chore(test): Fixes RNSentryAndroidTester compatibility with AS Ladybug #4409

merged 4 commits into from
Jan 10, 2025

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jan 2, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes RNSentryAndroidTester compatibility with AS Ladybug

💡 Motivation and Context

The Android tests weren't running on Android Studio LadyBug

💚 How did you test it?

CI, Manual testing

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis changed the title chore(test): Fixes compatibility with AS Ladybug chore(test): Fixes RNSentryAndroidTester compatibility with AS Ladybug Jan 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.88 ms 426.46 ms -0.42 ms
Size 17.75 MiB 20.11 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8ae23a7 526.83 ms 513.38 ms -13.45 ms
61310e1 464.42 ms 452.47 ms -11.95 ms
13f280b 486.16 ms 472.45 ms -13.71 ms
c6f01ea 486.20 ms 486.98 ms 0.77 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
cdf2bdf 448.42 ms 443.42 ms -5.00 ms
de59d3a 486.48 ms 495.66 ms 9.18 ms
f06c879 408.41 ms 424.54 ms 16.13 ms
d2c32bb 448.85 ms 450.19 ms 1.34 ms
8ab11b6 462.10 ms 450.40 ms -11.70 ms

App size

Revision Plain With Sentry Diff
8ae23a7 17.74 MiB 20.07 MiB 2.34 MiB
61310e1 17.74 MiB 20.08 MiB 2.35 MiB
13f280b 17.74 MiB 20.08 MiB 2.34 MiB
c6f01ea 17.74 MiB 20.10 MiB 2.36 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
cdf2bdf 17.74 MiB 20.10 MiB 2.36 MiB
de59d3a 17.74 MiB 20.10 MiB 2.36 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB
d2c32bb 17.74 MiB 20.08 MiB 2.34 MiB
8ab11b6 17.74 MiB 20.09 MiB 2.35 MiB

@antonis
Copy link
Collaborator Author

antonis commented Jan 2, 2025 •
edited
Loading

There seems to be an issue with Boost availability affecting both the Android and iOS metric tests. This seems unrelated with this PR.

@antonis antonis marked this pull request as ready for review January 3, 2025 09:10
@antonis
Copy link
Collaborator Author

antonis commented Jan 3, 2025

There seems to be an issue with Boost availability affecting both the Android and iOS metric tests. This seems unrelated with this PR.

Opened an issue to track the CI failure and resolve it
#4413

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.63 ms 1210.78 ms -10.84 ms
Size 2.63 MiB 3.68 MiB 1.05 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5bc97b+dirty 1230.63 ms 1234.83 ms 4.20 ms
205982c+dirty 1226.83 ms 1234.36 ms 7.53 ms
57448c5+dirty 1228.73 ms 1235.90 ms 7.16 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
946a600+dirty 1238.20 ms 1236.85 ms -1.35 ms
b8ff156+dirty 1236.51 ms 1234.53 ms -1.98 ms
0ebca77+dirty 1220.75 ms 1222.81 ms 2.06 ms
9385d74+dirty 1215.18 ms 1216.43 ms 1.25 ms
9dabcce+dirty 1231.39 ms 1238.02 ms 6.63 ms
690220d+dirty 1228.27 ms 1233.55 ms 5.29 ms

App size

Revision Plain With Sentry Diff
e5bc97b+dirty 2.36 MiB 3.10 MiB 753.14 KiB
205982c+dirty 2.36 MiB 3.11 MiB 760.04 KiB
57448c5+dirty 2.36 MiB 3.10 MiB 752.34 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
946a600+dirty 2.36 MiB 3.10 MiB 759.74 KiB
b8ff156+dirty 2.36 MiB 3.11 MiB 759.80 KiB
0ebca77+dirty 2.36 MiB 3.04 MiB 698.33 KiB
9385d74+dirty 2.36 MiB 3.10 MiB 759.78 KiB
9dabcce+dirty 2.36 MiB 3.10 MiB 757.52 KiB
690220d+dirty 2.36 MiB 3.10 MiB 753.57 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.45 ms 436.52 ms 54.07 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8fe7c9d+dirty 363.91 ms 429.93 ms 66.03 ms
83f6f6c+dirty 442.82 ms 487.48 ms 44.66 ms
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
d16beca+dirty 389.49 ms 423.86 ms 34.37 ms
b95b8af+dirty 392.94 ms 428.00 ms 35.06 ms
ac41368+dirty 395.91 ms 451.17 ms 55.26 ms
9dabcce+dirty 359.66 ms 430.73 ms 71.08 ms
c639edf+dirty 363.39 ms 414.78 ms 51.39 ms
79976dd+dirty 373.25 ms 404.64 ms 31.39 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms

App size

Revision Plain With Sentry Diff
8fe7c9d+dirty 7.15 MiB 8.38 MiB 1.23 MiB
83f6f6c+dirty 7.15 MiB 8.37 MiB 1.22 MiB
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
d16beca+dirty 7.15 MiB 8.37 MiB 1.22 MiB
b95b8af+dirty 7.15 MiB 8.38 MiB 1.23 MiB
ac41368+dirty 7.15 MiB 8.39 MiB 1.24 MiB
9dabcce+dirty 7.15 MiB 8.37 MiB 1.22 MiB
c639edf+dirty 7.15 MiB 8.35 MiB 1.20 MiB
79976dd+dirty 7.15 MiB 8.38 MiB 1.23 MiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.10 ms 1237.20 ms 6.10 ms
Size 3.19 MiB 4.25 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5bc97b+dirty 1229.17 ms 1227.64 ms -1.54 ms
205982c+dirty 1228.06 ms 1237.72 ms 9.66 ms
57448c5+dirty 1244.65 ms 1249.20 ms 4.55 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
946a600+dirty 1236.12 ms 1234.94 ms -1.18 ms
b8ff156+dirty 1238.92 ms 1239.57 ms 0.66 ms
0ebca77+dirty 1209.30 ms 1220.33 ms 11.03 ms
9385d74+dirty 1239.51 ms 1245.88 ms 6.37 ms
9dabcce+dirty 1247.71 ms 1239.18 ms -8.53 ms
690220d+dirty 1227.45 ms 1221.67 ms -5.78 ms

App size

Revision Plain With Sentry Diff
e5bc97b+dirty 2.92 MiB 3.66 MiB 758.40 KiB
205982c+dirty 2.92 MiB 3.67 MiB 772.63 KiB
57448c5+dirty 2.92 MiB 3.66 MiB 756.65 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
946a600+dirty 2.92 MiB 3.67 MiB 772.40 KiB
b8ff156+dirty 2.92 MiB 3.67 MiB 772.38 KiB
0ebca77+dirty 2.92 MiB 3.61 MiB 705.12 KiB
9385d74+dirty 2.92 MiB 3.67 MiB 772.40 KiB
9dabcce+dirty 2.92 MiB 3.67 MiB 770.02 KiB
690220d+dirty 2.92 MiB 3.66 MiB 758.77 KiB

@antonis antonis mentioned this pull request Jan 8, 2025
Closed
krystofwoldrich
krystofwoldrich approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you.

@antonis antonis merged commit ffd7b2b into main Jan 10, 2025
70 checks passed
@antonis antonis deleted the antonis/RNSentryAndroidTester-AS-Fix branch January 10, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @krystofwoldrich