Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vendor): Update license and attribution style #2949

Merged
merged 2 commits into from
Apr 6, 2023
Merged

chore(vendor): Update license and attribution style #2949

merged 2 commits into from
Apr 6, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1268.80 ms 1283.30 ms 14.50 ms
Size 2.92 MiB 3.40 MiB 488.07 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms

App size

Revision Plain With Sentry Diff
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 277.29 ms 337.60 ms 60.30 ms
Size 7.15 MiB 8.04 MiB 910.85 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms

App size

Revision Plain With Sentry Diff
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1251.57 ms 1255.56 ms 3.99 ms
Size 2.36 MiB 2.83 MiB 481.10 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms

App size

Revision Plain With Sentry Diff
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) April 6, 2023 12:49
@krystofwoldrich krystofwoldrich merged commit d0bf494 into main Apr 6, 2023
@krystofwoldrich krystofwoldrich deleted the kw-fix-licenses branch April 6, 2023 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 326.17 ms 360.35 ms 34.18 ms
Size 17.73 MiB 19.75 MiB 2.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms

App size

Revision Plain With Sentry Diff
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brustolin brustolin brustolin approved these changes

@marandaneto marandaneto Awaiting requested review from marandaneto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add attribution and the text of their license at the top of the file
2 participants
@krystofwoldrich @brustolin