Skip to content

Commit

Permalink
fix(ttd): Make all options of startTTID optional (#3867)
Browse files Browse the repository at this point in the history
  • Loading branch information
krystofwoldrich authored Jun 7, 2024
1 parent 229ffc0 commit 10d066c
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -5,6 +5,7 @@
### Fix

- Add missing logs to dropped App Start spans ([#3861](https://github.com/getsentry/sentry-react-native/pull/3861))
- Make all options of `startTimeToInitialDisplaySpan` optional ([#3867](https://github.com/getsentry/sentry-react-native/pull/3867))
- Add Span IDs to Time to Display debug logs ([#3868](https://github.com/getsentry/sentry-react-native/pull/3868))

### Dependencies
5 changes: 4 additions & 1 deletion src/js/tracing/timetodisplay.tsx
Original file line number Diff line number Diff line change
@@ -86,7 +86,10 @@ function TimeToDisplay(props: {
* Returns current span if already exists in the currently active span.
*/
export function startTimeToInitialDisplaySpan(
options?: Exclude<StartSpanOptions, 'op' | 'name'> & { name?: string; isAutoInstrumented?: boolean },
options?: Omit<StartSpanOptions, 'op' | 'name'> & {
name?: string;
isAutoInstrumented?: boolean
},
): Span | undefined {
const activeSpan = getActiveSpan();
if (!activeSpan) {

0 comments on commit 10d066c

Please sign in to comment.