Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tox setup for AWS Lambda integration #4076

Merged

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Feb 19, 2025

Because we changed our AWS Lambda test suite to not create real Lambda functions but rather run a Lambda environment locally, we do not need all the code necessary for handling the authentication to AWS in the test suite.

This PR removes all the AWS auth related code and als moves the AWS Lambda testsuite again into the "Cloud" group of test suites, because it is a "normal" test suite again.

The PR that includes the change to have a local Lambda environment is here: #3988

@antonpirker antonpirker force-pushed the antonpirker/better-aws-tests branch from 2cde31a to a89b3c4 Compare February 19, 2025 13:48
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.49%. Comparing base (38fa8c0) to head (bad4994).
Report is 1 commits behind head on antonpirker/better-aws-tests.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           antonpirker/better-aws-tests    #4076      +/-   ##
================================================================
+ Coverage                         79.46%   79.49%   +0.03%     
================================================================
  Files                               140      140              
  Lines                             15521    15521              
  Branches                           2631     2631              
================================================================
+ Hits                              12334    12339       +5     
+ Misses                             2353     2351       -2     
+ Partials                            834      831       -3     

see 2 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as draft February 20, 2025 12:42
@antonpirker antonpirker marked this pull request as ready for review February 24, 2025 09:37
@antonpirker antonpirker requested review from sentrivana and szokeasaurusrex and removed request for sentrivana February 24, 2025 09:39
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#feelsgood

There is couple more aws-* scripts in scripts/, do we still need any of those?

@antonpirker
Copy link
Member Author

Those scripts are still needed if someone is doing manual testing (creating a Lambda function by hand and wanting to add the Layer to it and stuff like this)

I cleaned the scripts/ directory up a bit (and removed some other Lambda function that is not necessary anymore.

@antonpirker antonpirker merged commit bfa0312 into antonpirker/better-aws-tests Feb 24, 2025
135 checks passed
@antonpirker antonpirker deleted the antonpirker/update-aws-tox-setup branch February 24, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants