-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tox setup for AWS Lambda integration #4076
Update tox setup for AWS Lambda integration #4076
Conversation
2cde31a
to
a89b3c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## antonpirker/better-aws-tests #4076 +/- ##
================================================================
+ Coverage 79.46% 79.49% +0.03%
================================================================
Files 140 140
Lines 15521 15521
Branches 2631 2631
================================================================
+ Hits 12334 12339 +5
+ Misses 2353 2351 -2
+ Partials 834 831 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#feelsgood
There is couple more aws-*
scripts in scripts/
, do we still need any of those?
Those scripts are still needed if someone is doing manual testing (creating a Lambda function by hand and wanting to add the Layer to it and stuff like this) I cleaned the |
Because we changed our AWS Lambda test suite to not create real Lambda functions but rather run a Lambda environment locally, we do not need all the code necessary for handling the authentication to AWS in the test suite.
This PR removes all the AWS auth related code and als moves the AWS Lambda testsuite again into the "Cloud" group of test suites, because it is a "normal" test suite again.
The PR that includes the change to have a local Lambda environment is here: #3988