ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum

[mgaligniana]

Fixes GH-2696

[codecov]

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.55%. Comparing base (eeedd11) to head (89160fc).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
sentry_sdk/integrations/fastapi.py	50.00%	1 Missing ⚠️
sentry_sdk/integrations/gcp.py	0.00%	1 Missing ⚠️
sentry_sdk/integrations/litestar.py	50.00%	1 Missing ⚠️
sentry_sdk/integrations/starlette.py	66.66%	1 Missing ⚠️
sentry_sdk/integrations/starlite.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3889      +/-   ##
==========================================
+ Coverage   79.53%   79.55%   +0.02%     
==========================================
  Files         140      140              
  Lines       15517    15521       +4     
  Branches     2630     2631       +1     
==========================================
+ Hits        12341    12348       +7     
+ Misses       2340     2338       -2     
+ Partials      836      835       -1     

Files with missing lines	Coverage Δ
sentry_sdk/integrations/aiohttp.py	81.25% <ø> (ø)
sentry_sdk/integrations/arq.py	89.84% <100.00%> (ø)
sentry_sdk/integrations/asgi.py	85.61% <100.00%> (ø)
sentry_sdk/integrations/aws_lambda.py	30.91% <100.00%> (ø)
sentry_sdk/integrations/celery/__init__.py	86.55% <100.00%> (ø)
sentry_sdk/integrations/chalice.py	89.18% <100.00%> (ø)
sentry_sdk/integrations/django/__init__.py	81.48% <100.00%> (ø)
sentry_sdk/integrations/grpc/aio/server.py	86.44% <100.00%> (ø)
sentry_sdk/integrations/grpc/server.py	76.31% <100.00%> (ø)
sentry_sdk/integrations/huey.py	16.66% <ø> (ø)
... and 13 more

... and 3 files with indirect coverage changes

[mgaligniana]

Linter is failing because of:

Should I fix them in a different commit?

[antonpirker]

nice! thanks for the cleanup

[antonpirker]

Linter is failing because of:

Should I fix them in a different commit?

no, this is because of a new release of mypy. I will fix this.

[antonpirker]

This breaks a lot of tests, because the full enum ends up in the envelope that is sent to Sentry and not the .value of the enum. Can you please fix this?

[antonpirker]

Please fix the tests, by making sure the .value of the enum (the string) ends up in the envelop json payload that is sent to Sentry.

[mgaligniana]

Thank you @antonpirker! Now linter and tests passing! 💪

[mgaligniana]

Hi Anton! Just curious why did we have to delete the .value again. Let me know if there is something I can help

[antonpirker]

I just made it so one does not have to always use the .value, so the enum is easier to use and error due to missing .value are not happening. otherwise it is a really cool change and I will merge it today

[antonpirker]

This is now ready to be merged!

[mgaligniana]

Thank you @antonpirker !!

[mgaligniana]

I didn't see this! Thanks for the explanation!