New branch with changes, because the refactoring made using the old b… #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
approved these changes
Jun 18, 2024
antonpirker
merged commit c883fa8
into
antonpirker/fix-celery-beat-refactoring
111 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes #3155
Because the refactoring done before made applying the old branch impossible.
After refactoring the Celery Beat integration there was a regression, where the
ok/errorcheck ins for crons where not sent.We reverted the refactoring here: #3144
This PR:
https://github.com/getsentry/sentry-python/pull/3155/files#diff-a05979007fa0398cc22f7b4910ccd3fde27fdea262a6137d1abdc676c633fcdcR75
https://github.com/getsentry/sentry-python/pull/3155/files#diff-6080c59a09cd8a2064cb87c5e2512c0589dda02f0ad2f46c94f774b0e645676fR56
After we have merged this we can revert the revert linked above.
Fixes #3145