Redis Cache Module - 1 - Prepare Code #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Szoke <[email protected]>
sentrivana
approved these changes
May 21, 2024
There was a problem hiding this comment.
This looks really great. Couple suggestions:
- I'd rename
common_async.pyandcommon_sync.pyto_async_common.pyand_sync_common.pyto mirror_asgi_common.pyand_wsgi_common.py - Regarding
rediscluster.pyandredis_cluster.py, this will probably get confusing fast. Maybe we can call the old oneredis_cluster_legacy.pyorredis_py_cluster.py?
|
Makes sense! I updated the code. Lets see if CI is happy! |
…is-cache-module-1
…is-cache-module-1
…is-cache-module-1
…is-cache-module-1
* Some work to use same function for queries and caches module * Moved functions to better place * Added tests * Fix * Tests and linting * Thats important for Python 3.6 * Fixed some tests * Removed ipdb * more fixing * Cleanup * Async cache spans * Added async tests * Fixed async tests * Guard for not running async tests when there is no async fakeredis for that python version * linting * Use new names for ops * Renamed for consistency * fix _get_op() * Cleaning up unused properties/parameters * Use _get_safe_key in Django integration * Fixed typing * More tests * Only return the keys in set_many, makes more sense * Linting * Cleanup * fix(clickhouse): `_sentry_span` might be missing (#3096) We started auto-enabling the ClickHouse integration in 2.0+. This led to it getting auto-enabled also for folks using ClickHouse with Django via `django-clickhouse-backend`, but it turns out that the integration doesn't work properly with `django-clickhouse-backend` and leads to `AttributeError: 'Connection' object has no attribute '_sentry_span'`. * Make _get_safe_key work for all multi key methods in django and redis * Fixed kwargs case and updated tests * Updated tests * cache.set should be cache.put * Fix `cohere` testsuite for new release of `cohere`. (#3098) * Check for new class to signal end of stream --------- Co-authored-by: Ivana Kellyerova <[email protected]>
…ry/sentry-python into antonpirker/redis-cache-module-1
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Make the redis integration fit for sending Span data that is eligible for the Caches performance module in Sentry. --------- Co-authored-by: Daniel Szoke <[email protected]> Co-authored-by: Ivana Kellyerova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
redisintegration fit for sending Span data that is eligible for the Caches performance module in Sentry.There will be a chain of PRs.
This first PR is organizing the existing code in modules to make it more maintainable. The code has not changed, only reformatted.
Part 1/2 for fixing #2965
Part 2 is here: #3075