Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Define types at runtime #2914

Merged
merged 5 commits into from
Mar 27, 2024
Merged

ref: Define types at runtime #2914

merged 5 commits into from
Mar 27, 2024

Conversation

szokeasaurusrex
Copy link
Member

Set types in sentry_sdk.types to None at runtime. This allows the types to be imported from outside if TYPE_CHECKING guards.

Fixes GH-2909

antonpirker and others added 2 commits March 27, 2024 14:41
@antonpirker @szokeasaurusrex
Explicit reexport of types (#2866)
86fdea0 
* Explicitly reexport types to make strict mypy setups happy
@szokeasaurusrex
ref: Define types at runtime
fe5d54a
@szokeasaurusrex szokeasaurusrex changed the base branch from master to szokeasaurusrex/explicit-type-reexport March 27, 2024 14:02
asottile-sentry
asottile-sentry reviewed Mar 27, 2024
View reviewed changes
sentry_sdk/types.py Outdated Show resolved Hide resolved
sentry_sdk/types.py Outdated Show resolved Hide resolved
@szokeasaurusrex szokeasaurusrex mentioned this pull request Mar 27, 2024
Merged
asottile-sentry
asottile-sentry approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from szokeasaurusrex/explicit-type-reexport to master March 27, 2024 14:15
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) March 27, 2024 14:18
@szokeasaurusrex szokeasaurusrex merged commit 6c2eb53 into master Mar 27, 2024
123 of 124 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/define-types-at-runtime branch March 27, 2024 14:38
This was referenced Jun 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile-sentry asottile-sentry asottile-sentry approved these changes

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not export types behind TYPE_CHECKING
3 participants
@szokeasaurusrex @asottile-sentry @antonpirker