-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling): Add thread data to spans #2843
Conversation
As per getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in #2830.
2344d79
to
95331f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
This somewhat weakens our tests, but after talking with the other Python people and also confirmed with Ingest that if there is an onknown value in span data it is just stored anyhow. I think this is fine.
👍 I'm not sure there's a stronger test we can add here as the thread ids are unstable. The only alternative I can think of is to mock it in each place which seems worse because now every test is concerned about mocking the thread id data appropriately to pass. Which is why I opted for each test to just assert that the relevant properties are added to the span data. |
As per getsentry/rfcs#75 getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in #2830.