fix(crons): Fix KeyError in capture_checkin if SDK is not initialized #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Sentry SDK was not initialized, any calls to capture_checkin() raised a KeyError. This made all calls to functions decorated with @sentry_sdk.monitor() fail, because capture_checkin() is always called within the decorator.
|
To fix the merge conflicts I had to create a new PR: #2073 Will close this one here (you will be set as author of the other one) |
auto-merge was automatically disabled
May 4, 2023 06:41
Pull request was closed
|
@antonpirker Hi, thanks for the update. I've noticed a change in the crons implementation, but didn't get to review it and update/close my PR. Thanks for the new PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Sentry SDK was not initialized, any calls to
capture_checkin()raised aKeyError. This made all calls to functions decorated with@sentry_sdk.monitor()fail, becausecapture_checkin()is always called within the decorator.This caused trouble especially in local dev environments, which usually does not have Sentry integration enabled.