fix(worker): Log data-dropping events with error #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we fail to flush all events, or when the queue overflows, this should be an error event. I have some concerns about when the user uses things like logly, which are known for sending out blocking HTTP requests from within their log handler. However I believe they don't register that handler for all loggers.
untitaker
referenced
this pull request
Feb 22, 2021
Co-authored-by: Markus Unterwaditzer <[email protected]>
untitaker
force-pushed
the
fix/worker-log-levels
branch
from
c222996 to
d72f1d2
Compare
alexmv
added a commit
to CAVaccineInventory/vial
that referenced
this pull request
Mar 5, 2021
Interestingly, sentry has just hit 1.0.0! None of the nominally breaking changes[1] look relevant to our minimal usage: > - Feat: Moved auto_session_tracking experimental flag to a proper > option and removed session_mode, hence enabling release health by > default getsentry/sentry-python#994 > > - Fixed Django transaction name by setting the name to > request.path_info rather than request.path > > - Fix for tracing by getting HTTP headers from span rather than > transaction when possible getsentry/sentry-python#1035 > > - Fix for Flask transactions missing request body in non errored > transactions getsentry/sentry-python#1034 > > - Fix for honoring the X-Forwarded-For header getsentry/sentry-python#1037 > > - Fix for worker that logs data dropping of events with level error > getsentry/sentry-python#1032 [1] https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md
This was referenced Mar 8, 2021
Closed
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fail to flush all events, or when the queue overflows, this
should be an error event.
I have some concerns about when the user uses things like logly, which
are known for sending out blocking HTTP requests from within their log
handler. However I believe they don't register that handler for all
loggers.