Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend API with ptr/len-string interfaces #827

Merged
merged 36 commits into from
Apr 25, 2023
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
9a1c0fc
feat: provide ptr+len string interfaces
supervacuus Mar 28, 2023
6da96ca
fix GEN_SENTRY__VALUE_TRANSACTION_CONTEXT_NEW
supervacuus Mar 28, 2023
df6f501
Make tests run on Windows
supervacuus Mar 29, 2023
9af0b2b
Fix pytest macOS version assertions
supervacuus Mar 29, 2023
2cf44f5
Make ignored warning work on clang/gcc
supervacuus Mar 29, 2023
4744ebe
reformat test_value.c
supervacuus Mar 29, 2023
17ba2bb
Update pytest deps
supervacuus Mar 29, 2023
1b702a8
Update CHANGELOG.md
supervacuus Mar 29, 2023
f77ac24
Fix linter woes
supervacuus Mar 29, 2023
649ed39
clang-format 15 changes (puh)
supervacuus Mar 29, 2023
277ba18
Fix code-checker issue in test_basic.c
supervacuus Mar 29, 2023
b7f8700
Fix span/txn ownership in test_tracing
supervacuus Mar 29, 2023
336cec0
fix typo
supervacuus Mar 29, 2023
5206243
minor integration-test clean-ups after battling said test
supervacuus Mar 29, 2023
f7781d8
get rid of macros and increase coverage
supervacuus Apr 18, 2023
df5d329
reintroduce locale header to sentry_utils.c
supervacuus Apr 18, 2023
0831089
clean up txns in unit-tests
supervacuus Apr 18, 2023
c0b5e7f
Cleanup curl after curl_easy_perform
supervacuus Apr 18, 2023
251ba77
Use easy_reset instead of easy_cleanup to check macos clang leak
supervacuus Apr 18, 2023
f2292f6
Further guards & fixes thx to unit-tests
supervacuus Apr 19, 2023
c365275
Implement sentry_span_start_child_n
supervacuus Apr 19, 2023
e3d4508
use sentry_boot.h in sentry_value.c
supervacuus Apr 19, 2023
32db9d5
Implement sentry_set_fingerprint_n
supervacuus Apr 19, 2023
65963e1
reformat to silence lint.
supervacuus Apr 19, 2023
0618453
get rid of sentry.h refs in unit-tests
supervacuus Apr 19, 2023
2b3a5f6
Implement remaining wchar_t options interfaces for windows.
supervacuus Apr 19, 2023
16c8c30
fix sentry__path_from_str[_n] on windows
supervacuus Apr 24, 2023
409c27d
sentry__path_from_str_n: use returned length of converted wide-chars.
supervacuus Apr 24, 2023
ded5a3f
fix sentry__string_clone[_n] naming
supervacuus Apr 24, 2023
f904339
format
supervacuus Apr 24, 2023
6f72973
fix affected unixy functions after changes on windows
supervacuus Apr 24, 2023
afd70a6
get rid of SYSTEM_VERSION_COMPAT in Makefile
supervacuus Apr 25, 2023
4b1ec83
do curl_global_cleanup() after curl_easy_cleanup() in transport free
supervacuus Apr 25, 2023
042329e
suppress SCDynamicStoreCopyProxiesWithOptions in LSAN
supervacuus Apr 25, 2023
381b4cb
fix len-parameter name in header
supervacuus Apr 25, 2023
5a4664a
cosmetic cleanups.
supervacuus Apr 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: make style
- run: |
sudo apt update
sudo apt install clang-format-15
make style-15

build-ios:
name: Xcode Build for iOS
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

**Features**:

- Extend API with ptr/len-string interfaces. ([#827](https://github.com/getsentry/sentry-native/pull/827))

## 0.6.1

**Fixes**:
Expand Down
10 changes: 9 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ test-unit: update-test-discovery CMakeLists.txt
./unit-build/sentry_test_unit
.PHONY: test-unit

# SYSTEM_VERSION_COMPAT=0 is required (starting with BigSur) to get the correct macOS version for context assertions:
# https://developer.apple.com/documentation/macos-release-notes/macos-big-sur-11_0_1-release-notes#Third-Party-Apps
test-integration: setup-venv
.venv/bin/pytest tests --verbose
SYSTEM_VERSION_COMPAT=0 .venv/bin/pytest tests --verbose
supervacuus marked this conversation as resolved.
Show resolved Hide resolved
.PHONY: test-integration

test-leaks: update-test-discovery CMakeLists.txt
Expand Down Expand Up @@ -83,3 +85,9 @@ style: setup-venv
@.venv/bin/python ./scripts/check-clang-format.py -r examples include src tests/unit
@.venv/bin/black --diff --check tests
.PHONY: style

# TODO: workaround for clang-format 15+ where local formatting breaks with clang-format-14 based style checks on CI
style-15: setup-venv
@.venv/bin/python ./scripts/check-clang-format.py --clang-format-executable /usr/bin/clang-format-15 -r examples include src tests/unit
@.venv/bin/black --diff --check tests
.PHONY: style-15
Loading