Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 32 bit linux builds and gcc 4.9 #291

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

eakoli
Copy link
Contributor

@eakoli eakoli commented Jun 10, 2020

Adds option to enable 32 bit linux builds when on a 64bit host.
Links librt explicit in test suites (needed by older gcc chains that don't automatically manage it.)

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

We do test for 32-bit GCC7 already:

CC: gcc-7 -m32
CXX: g++-7 -m32
TEST_X86: 1

if sys.platform == "win32" and os.environ.get("TEST_X86"):
configcmd.append("-AWin32")

Would be nice to adapt the code to also do the right thing in this case

tests/unit/CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@eakoli eakoli force-pushed the feat-linux-32-gcc-49 branch from 3a8dd23 to 0a090df Compare June 11, 2020 15:15
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I meant concerning the CI setup: can you remove the explicit -m32 flag from the CI config, and rather update the test runner to pass down your newly introduced cmake flag when the TEST_X86 flag is set?

@eakoli eakoli force-pushed the feat-linux-32-gcc-49 branch from 4638273 to 4c36603 Compare June 16, 2020 18:31
tests/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Arpad Borsos <[email protected]>
@Swatinem Swatinem merged commit 1801f07 into getsentry:master Jun 16, 2020
irov pushed a commit to irov/sentry-native that referenced this pull request Jun 17, 2020
@eakoli eakoli deleted the feat-linux-32-gcc-49 branch July 27, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants