-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows inproc backend #287
Windows inproc backend #287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a lot simpler than I would have imagined.
Please make sure to enable the integration tests for this:
sentry-native/tests/conditions.py
Line 10 in b85641b
has_inproc = sys.platform != "win32" |
Considering this was the only condition, you might as well just remove all its uses as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, run this through make format
once to fix all the codestyle issues ;-)
@Swatinem Is there any way for me to get the details about why the checks are failing? |
cdbc6d8
to
8d7a4fc
Compare
And then it was hanging there for 60 minutes. Its the same problem that would be fixed by #284 I think. Thats still waiting for review. |
Yeah, I'm pretty sure that is the same issue which I have with breakpad. |
The necessary PR just landed on master. Can you please rebase? Then this should be good to go. |
8d7a4fc
to
5b8cc22
Compare
Amazing stuff! Thanks so much ;-) |
Updated inproc backend to support windows via the UnhandledExceptionFilter