Skip to content

Commit

Permalink
ref/ci: Update black as well as Windows jobs to unbreak CI (#691, #692)
Browse files Browse the repository at this point in the history
This aggressively bumps black up to a new version to fix
our linter jobs in CI. This is fine because the use of Python 
is exclusively confined to integration tests, which makes
the impact of this update fairly small.

This change also updates the CI to remove the job running
tests on a Windows Server 2016 environment as it is now
deprecated and can no longer be used. A job running
the same tests on Windows Server 2019 has been created
to replace the removed job, as `windows-latest` now
uses Windows Server 2022.
  • Loading branch information
relaxolotl authored Mar 30, 2022
1 parent 9eecb1b commit 7d2a4b6
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ jobs:
ERROR_ON_WARNINGS: 1
SYSTEM_VERSION_COMPAT: 0
RUN_ANALYZER: asan,llvm-cov
- name: Windows (VS2017, 32bit)
os: vs2017-win2016
- name: Windows (VS2019)
os: windows-2019
TEST_X86: 1
- name: Windows (latest)
os: windows-latest
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
- New API to check whether the application has crashed in the previous run: `sentry_get_crashed_last_run()` and `sentry_clear_crashed_last_run()` ([#685](https://github.com/getsentry/sentry-native/pull/685)).
- Allow overriding the SDK name at build time - set the `SENTRY_SDK_NAME` CMake cache variable.

**Fixes**:
- Updated CI as well as list of supported platforms to reflect Windows Server 2016, and therefore MSVC 2017 losing active support.

## 0.4.15

**Fixes**:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ The SDK currently supports and is tested on the following OS/Compiler variations
- 64bit Linux with GCC 9
- 64bit Linux with clang 9
- 32bit Linux with GCC 7 (cross compiled from 64bit host)
- 64bit Windows with MSVC 2019
- 32bit Windows with MSVC 2017
- 32bit Windows with MSVC 2019
- 64bit Windows with MSVC 2022
- macOS Catalina with most recent Compiler toolchain
- Android API29 built by NDK21 toolchain
- Android API16 built by NDK19 toolchain
Expand Down
2 changes: 1 addition & 1 deletion tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
black==21.9b0
black==22.3.0
pytest==6.2.5
pytest-httpserver==1.0.1

0 comments on commit 7d2a4b6

Please sign in to comment.