Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Update CHANGELOG for 7.90.0 #9932

Merged
merged 15 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .size-limit.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,18 +86,21 @@ module.exports = [
name: '@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)',
path: 'packages/browser/build/bundles/bundle.tracing.replay.min.js',
gzip: false,
brotli: false,
limit: '260 KB',
},
{
name: '@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)',
path: 'packages/browser/build/bundles/bundle.tracing.min.js',
gzip: false,
brotli: false,
limit: '100 KB',
},
{
name: '@sentry/browser - ES6 CDN Bundle (minified & uncompressed)',
path: 'packages/browser/build/bundles/bundle.min.js',
gzip: false,
brotli: false,
limit: '70 KB',
},

Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 7.90.0

- feat(replay): Change to use preset quality values (#9903)
- fix(replay): Adjust development hydration error messages (#9922)
- fix(sveltekit): Add `types` field to package.json `exports` (#9926)

## 7.89.0

### Important Changes
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"yalc:publish": "lerna run yalc:publish"
},
"volta": {
"node": "20.10.0",
"node": "18.17.0",
"yarn": "1.22.19"
},
"workspaces": [
Expand Down Expand Up @@ -88,8 +88,8 @@
"@rollup/plugin-replace": "^3.0.1",
"@rollup/plugin-sucrase": "^4.0.3",
"@rollup/plugin-typescript": "^8.3.1",
"@size-limit/preset-small-lib": "~9.0.0",
"@size-limit/webpack": "~9.0.0",
"@size-limit/file": "~11.0.1",
"@size-limit/webpack": "~11.0.1",
"@strictsoftware/typedoc-plugin-monorepo": "^0.3.1",
"@types/chai": "^4.1.3",
"@types/jest": "^27.4.1",
Expand Down Expand Up @@ -124,7 +124,7 @@
"rollup-plugin-license": "^2.6.1",
"rollup-plugin-terser": "^7.0.2",
"sinon": "^7.3.2",
"size-limit": "~9.0.0",
"size-limit": "~11.0.1",
"ts-jest": "^27.1.4",
"ts-node": "10.9.1",
"typedoc": "^0.18.0",
Expand Down
41 changes: 18 additions & 23 deletions packages/browser-integration-tests/utils/replayHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,40 +105,35 @@ export function waitForReplayRequest(
* Wait until a callback returns true, collecting all replay responses along the way.
* This can be useful when you don't know if stuff will be in one or multiple replay requests.
*/
export function waitForReplayRequests(
export async function waitForReplayRequests(
page: Page,
callback: (event: ReplayEvent, res: Response) => boolean,
timeout?: number,
): Promise<Response[]> {
const responses: Response[] = [];

return new Promise<Response[]>(resolve => {
void page.waitForResponse(
res => {
const req = res.request();
await page.waitForResponse(
res => {
const req = res.request();

const event = getReplayEventFromRequest(req);
const event = getReplayEventFromRequest(req);

if (!event) {
return false;
}
if (!event) {
return false;
}

responses.push(res);
responses.push(res);

try {
if (callback(event, res)) {
resolve(responses);
return true;
}
try {
return callback(event, res);
} catch {
return false;
}
},
timeout ? { timeout } : undefined,
);

return false;
} catch {
return false;
}
},
timeout ? { timeout } : undefined,
);
});
return responses;
}

export function isReplayEvent(event: Event): event is ReplayEvent {
Expand Down
10 changes: 8 additions & 2 deletions packages/browser/src/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {
dsn: this.getDsn(),
tunnel: this.getOptions().tunnel,
});
void this._sendEnvelope(envelope);

// _sendEnvelope should not throw
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this._sendEnvelope(envelope);
}

/**
Expand Down Expand Up @@ -137,6 +140,9 @@ export class BrowserClient extends BaseClient<BrowserClientOptions> {
DEBUG_BUILD && logger.log('Sending outcomes:', outcomes);

const envelope = createClientReportEnvelope(outcomes, this._options.tunnel && dsnToString(this._dsn));
void this._sendEnvelope(envelope);

// _sendEnvelope should not throw
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this._sendEnvelope(envelope);
}
}
Loading
Loading