Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(browser): Refactor browser integrations to functional style #9918

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 19, 2023

Eventually we may think about merging the LinkedErrors integration with the core one, but for now this should be OK...

@mydea mydea requested a review from AbhiPrasad December 19, 2023 15:11
@mydea mydea self-assigned this Dec 19, 2023
Copy link
Contributor

github-actions bot commented Dec 19, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.33 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.72 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.33 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.41 KB (-0.04% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.06 KB (+0.12% 🔺)
@sentry/browser - Webpack (gzipped) 21.7 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.72 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.46 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.71 KB (-0.11% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.8 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.28 KB (-0.15% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.41 KB (-0.29% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.47 KB (-0.38% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.63 KB (+0.12% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.11 KB (-0.03% 🔽)
@sentry/react - Webpack (gzipped) 21.73 KB (-0.12% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.88 KB (-0.04% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.56 KB (-0.04% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.35 KB (0%)

@AbhiPrasad
Copy link
Member

curious size-bot shows increase - thought it would be opposite.

@mydea
Copy link
Member Author

mydea commented Dec 19, 2023

curious size-bot shows increase - thought it would be opposite.

Yeah, me too 🤔

@mydea
Copy link
Member Author

mydea commented Dec 19, 2023

OK, I reran it and I think it compared against an older develop state.

@mydea mydea merged commit dc76369 into develop Dec 20, 2023
89 checks passed
@mydea mydea deleted the fn/browser-functional-intergations branch December 20, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants