Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(feedback): Refactor attaching replay id to feedback event to use hooks #9588

Merged
merged 4 commits into from
Nov 20, 2023
Merged

ref(feedback): Refactor attaching replay id to feedback event to use hooks #9588

merged 4 commits into from
Nov 20, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Nov 16, 2023 •
edited
Loading

Add a beforeSendFeedback hook that replay listens to, to attach replayId to the feedback event.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.61 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.72 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.01 KB (0%)
@sentry/browser - Webpack (gzipped) 21.32 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.03 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.71 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.38 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.34 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.85 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.92 KB (+0.13% 🔺)
@sentry/react - Webpack (gzipped) 21.36 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.66 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.15 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.1 KB (-0.36% 🔽)

@billyvg billyvg marked this pull request as ready for review November 16, 2023 23:06
@billyvg billyvg requested review from mydea and a team November 16, 2023 23:06
@billyvg billyvg requested a review from mydea November 17, 2023 15:41
@billyvg billyvg mentioned this pull request Nov 17, 2023
Merged
2 tasks
mydea
mydea approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@billyvg
ref(feedback): Refactor attaching replay id to feedback event to use …
ef6cd25 
…hooks

Add a `afterPrepareFeedback` hook that replay listens to, to attach replayId to the feedback event.
@billyvg
afterPrepareFeedback -> beforeSendFeedback
5db9fe1
@billyvg billyvg force-pushed the feat-feedback-refactor-attach-replay-id-to-use-hooks branch from e5863cd to 5db9fe1 Compare November 20, 2023 20:05
@billyvg billyvg merged commit f24ea88 into develop Nov 20, 2023
@billyvg billyvg deleted the feat-feedback-refactor-attach-replay-id-to-use-hooks branch November 20, 2023 21:21
billyvg added a commit that referenced this pull request Dec 1, 2023
@billyvg
feat(feedback): Include Feedback package in browser SDK (#9586)
f8cebde 
Add feedback to craft publish list, and export `Feedback` integration
from browser SDK

Depends on

- [x] #9588 
- [x] #9604

Relates to: getsentry/team-replay#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyvg @mydea