-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): allow direct pg module to enable esbuild support #9227
Conversation
caecb78
to
5b58bcc
Compare
5b58bcc
to
260a232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aldenquimby!
__DEBUG_BUILD__ && logger.error("Postgres Integration was unable to access 'pg-native' bindings."); | ||
return; | ||
} | ||
|
||
const { Client } = this._usePgNative ? pkg.native : pkg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg.native?.Client
is now nullable to align with @types/pg
. Unfortunately TS is not great with multiple boolean conditions. The changes here were the least disruptive I could come up with
@AbhiPrasad thank you! |
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).Background
Proposal
Alternatives
commonjsMagicComments
, that should do the trick