feat(browser): Export BrowserTracing from @sentry/browser

[timfish]

Ref #7342

This PR:

• Adds @sentry-internal/tracing as a dependency of @sentry/browser
• Exports BrowserTracing from root of @sentry/browser
• Ensures that BrowserTracing is excluded from main browser bundle
• Adds a call to addTracingExtensions from BrowserTracing constructor so this doesn't need to be called separately

[AbhiPrasad]

I wonder why the integration tests are failing 🤔

[timfish]

wonder why the integration tests are failing

Yep, strange. It looks like only the bundle tests are failing. Need to look into it further!

I guess at some point the tracing bundle will to move to @sentry/browser so that we can delete @sentry/tracing.

[timfish]

Ah, it looks like it's completely to do with test setup. I excluded BrowserTracing from the base @sentry/browser bundles and all the tests currently import @sentry/tracing too. Because I removed the @sentry/tracing import, that bundle no longer gets included in the tests.

I think maybe we need to split the tests into those that require tracing and those that do not.

[timfish]

I've rolled back the changes to the integration tests for now.

I think after this PR, the next steps might be:

• Move generation of bundle.tracing.*.js to @sentry/browser
• Fix integration tests to use the correct bundle

[mydea]

Just leaving a note to #7479 here, need to sync this (whichever is merged first) to make sure all is still good 😅

[mydea]

Hmm, should we export this from src/integrations/index.ts instead? As this is where you'd currently get this from e.g. in CDN bundles. Also where I hooked this in for #7479.

[timfish]

It might make more sense to put it in src/integrations/index.ts since it IS an integration. However, the Replay integration is exported just above this and I thought it might be better to keep all the __ROLLUP_EXCLUDE wrapped exports together near the comments describing why they shouldn't be deleted.

[mydea]

Hmm, good question... So I think either way we have to make sure it is available in both places, as that's where we currently have it. So both of these work as of today for CDN bundles:

new Sentry.BrowserTracing();
new Sentry.Integrations.BrowserTracing();

So TLDR I guess it's fine to export it from the root, but we need to make sure that it is also on Sentry.Integrations in CDN bundles.

[AbhiPrasad]

We can do this in a follow up given the bundle is already being generated from https://github.com/getsentry/sentry-javascript/blob/develop/packages/tracing/src/index.bundle.base.ts - so I think we should be fine.

[timfish]

Just leaving a note to #7479 here

Ah I see. These shims are empty plugins that warn when you're using a bundle without the type?

Will we either include the shim OR the integration? Are there cases where we'd include neither?

[AbhiPrasad]

Will we either include the shim OR the integration

Each bundle will either have a shim or the actual integration.

[AbhiPrasad]

Volta seems to be flaking pretty bad https://github.com/getsentry/sentry-javascript/actions/runs/4438668704/jobs/7790044090?pr=7472

There's a couple of user reports here: volta-cli/volta#1252

[timfish]

Volta seems to be flaking pretty bad

I've seen this at a smaller scale for a couple of months on the Electron repository. It may just be that the node.js download URLs are particularly flakey today!