Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Remove isInstanceOf check in Transaction constructor #5046

Merged
merged 1 commit into from
May 6, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/tracing/src/transaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
TransactionContext,
TransactionMetadata,
} from '@sentry/types';
import { dropUndefinedKeys, isInstanceOf, logger } from '@sentry/utils';
import { dropUndefinedKeys, logger } from '@sentry/utils';

import { IS_DEBUG_BUILD } from './flags';
import { Span as SpanClass, SpanRecorder } from './span';
Expand All @@ -22,7 +22,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
/**
* The reference to the current hub.
*/
private readonly _hub: Hub = getCurrentHub() as unknown as Hub;
private readonly _hub: Hub;

private _trimEnd?: boolean;

Expand All @@ -36,9 +36,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
public constructor(transactionContext: TransactionContext, hub?: Hub) {
super(transactionContext);

if (isInstanceOf(hub, Hub)) {
this._hub = hub as Hub;
}
this._hub = hub || getCurrentHub();

this.name = transactionContext.name || '';

Expand Down