Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update logo for dark or light theme #5037

Closed
wants to merge 1 commit into from

Conversation

mattjohnsonpint
Copy link
Contributor

Update logo to use media queries so it looks good on both dark and light themes.

See getsentry/sentry#34229 for screenshot of effect, or view readme on this branch after changing your theme.

#skip-changelog

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) May 4, 2022 20:20
@AbhiPrasad
Copy link
Member

Hey, thanks for making a PR! Atm we are only accepting PRs into 7.x, our upcoming major version of the SDK: master...7.x

See: #4882

Mind rebasing on to that?

@lforst
Copy link
Member

lforst commented May 5, 2022

The thing that @timfish mentioned in the electron repo also applies here I believe: getsentry/sentry-electron#479 (comment)

@mattjohnsonpint
Copy link
Contributor Author

Ok. I'll re-do this based on 7.x. Also, it will just use the Sentry purple logo, due to NPM rendering issues, as discussed at getsentry/sentry-electron#479 (comment). Thanks.

@mattjohnsonpint
Copy link
Contributor Author

Should we follow the following? https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to

@yordis - I tested that approach. Unfortunately it's broken when the image is wrapped in an link, and it renders even worse on NPM because you get both images.

auto-merge was automatically disabled May 5, 2022 19:52

Pull request was closed

@mattjohnsonpint mattjohnsonpint deleted the chore/fix-readme-logo branch May 5, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants