-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(bundles): Rename CDN bundles to be es6 per default #4958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
approved these changes
Apr 21, 2022
1 task
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 21, 2022
onurtemizkan
pushed a commit
that referenced
this pull request
Apr 21, 2022
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
AbhiPrasad
pushed a commit
that referenced
this pull request
May 30, 2022
Is it possible to move back to es5 by default? It's breaking next.js entirely on some browsers like safari ios 10 and more - vercel/next.js#38935 |
See #5452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will adjust the naming of our CDN bundle. All bundles named
*.es6*.js
will now be named*.js
and all bundles previously named*.js
will now be named*.es5*.js
.This effectively makes the ES6 browser bundles the new default.
Migration docs have already been updated in #4918
Ref: https://getsentry.atlassian.net/browse/WEB-838