Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eventprocessors): Add name field to EventProcessor #4932

Merged
merged 6 commits into from
Apr 14, 2022
Merged

feat(eventprocessors): Add name field to EventProcessor #4932

merged 6 commits into from
Apr 14, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented Apr 13, 2022 •
edited
Loading

Adds an identifier field to EventProcessor so we can log if an event processor drops an event.

Ref: https://getsentry.atlassian.net/browse/WEB-817

@lforst lforst marked this pull request as draft April 13, 2022 11:50
@lforst
Copy link
Member Author

lforst commented Apr 13, 2022

@AbhiPrasad before I continue with this: Is this the direction we want to go in?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 13, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.18 KB (+0.19% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.31 KB (-0.47% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.84 KB (-0.09% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.95 KB (-0.04% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.42 KB (+0.77% 🔺)
@sentry/browser - Webpack (minified) 81.22 KB (-0.6% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.46 KB (+0.79% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.96 KB (-0.19% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.04 KB (-0.12% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.41 KB (-0.29% 🔽)

@lforst lforst marked this pull request as ready for review April 13, 2022 16:13
@lforst lforst requested a review from AbhiPrasad April 13, 2022 16:13
@lforst lforst requested a review from AbhiPrasad April 14, 2022 07:38
@lforst lforst merged commit d5c1d58 into 7.x Apr 14, 2022
@lforst lforst deleted the lforst-named-event-processor branch April 14, 2022 12:47
@lforst lforst mentioned this pull request Apr 14, 2022
Merged
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 25, 2022
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@lforst @Lms24
feat(eventprocessors): Add name field to EventProcessor (#4932)
25487f7
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@lforst @lobsterkatie
feat: Add name field to EventProcessor (#4932)
6bfb589
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@lforst @lobsterkatie
feat: Add name field to EventProcessor (#4932)
ec5ebe9
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@lforst @AbhiPrasad
feat: Add name field to EventProcessor (#4932)
14946b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @AbhiPrasad