-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v7] Remove eventbuilder exports which were historically used in @sentry/electron
#4887
[v7] Remove eventbuilder exports which were historically used in @sentry/electron
#4887
Conversation
These exports were historically used in `@sentry/electron`, but are no longer being used by the Electron SDK or the React Native SDK, so they can be removed.
These exports were historically used in `@sentry/electron`, but are no longer being used by the Electron SDK or the React Native SDK, so they can be removed.
These exports were historically used in `@sentry/electron`, but are no longer being used by the Electron SDK or the React Native SDK, so they can be removed.
These exports were historically used in `@sentry/electron`, but are no longer being used by the Electron SDK or the React Native SDK, so they can be removed.
This is a breaking change that wasn't called out in the release notes, if I'm using these functions, what should I used instead |
Sorry this didn't end up highlighted as a breaking change in the release notes. What are you using these exports for? |
I was using them to pass an event to |
Hey @maclockard - thanks for reaching out. Here we expect folks you to just directly use Why are you preferring to use |
Why make folks who are manually setting some of the event fields manually set all of them? What I was doing was using the event builder methods to make an event then overriding some fields manually before capturing. |
We recommend folks use const myError = new Error(...);
Sentry.withScope((scope) => {
scope.addEventProcessor(event => {
if (badCondition) {
// don't send event to Sentry
return null;
}
event.X = ...
event.Y = ...
return event;
});
Sentry.captureException(myError);
}); We intentionally constrain the top level API surface so that we can more easily make improvements and changes without user impact. Both |
These exports aren't even used in the React Native SDK:
https://github.com/getsentry/sentry-react-native/blob/a8d5ac86e3c53c90ef8e190cc082bdac440bd2a7/src/js/backend.ts#L45-L61