Update ember dependencies #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Dec 9, 2021
packages/ember/tsconfig.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "extends": "../../tsconfig.json", | |||
| "compilerOptions": { | |||
| "target": "es2017", | |||
| "target": "es2020", | |||
There was a problem hiding this comment.
It was bumped in the ember-cli-typescript blueprint from 3.x to 4.x. I can also leave it as it was?
There was a problem hiding this comment.
I would prefer not to bump the target if we don't need to.
mydea
force-pushed
the
fn/ember-auto-import
branch
from
b7c0c39 to
7a6c173
Compare
|
Will this make |
|
I have not tried it yet, but it should work just fine I believe, if ember-auto-import v1 is the blocker :) I'll try to give it a spin in an ember 4 app! |
|
Very excited for this change 😁 |
AbhiPrasad
approved these changes
Dec 13, 2021
|
@mydea, mind rebasing the branch? We can ship this with the next release! |
|
Same for us - currently blocked upgrading to ember4.0 |
mydea
force-pushed
the
fn/ember-auto-import
branch
from
7a6c173 to
6bf2ef0
Compare
|
I rebased and pushed, tests are running! |
|
Merged! Next release will be late this week or early next week, so stay tuned for that! |
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
* Allow ember-auto-import 1.x or 2.x * Update ember-cli-typescript from 3.1.4 to 4.2.1 * Update ember-cli-htmlbars from 5.7.1 to 6.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies for @sentry/ember to their latest version:
ember-cli-htmlbarsfrom 5.7.1 to 6.0.1ember-cli-typescriptfrom 3.1.4 to 4.2.1ember-auto-importallow both 1.x and 2.xwebpackas a dev dependency, as that is needed by auto-import v2