Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(core): Make getTransport method on client optional #4013

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

kamilogorek
Copy link
Contributor

I changed it to optional instead of just adding ?. check to make sure that we won't forget to do that in case we use it in other places. We do the same with sendSession already.

Closes #3995

@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.32 KB (+0.01% 🔺)
@sentry/browser - Webpack 23.3 KB (0%)
@sentry/react - Webpack 23.33 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.77 KB (+0.02% 🔺)

@kamilogorek kamilogorek merged commit f96d47b into master Sep 27, 2021
@kamilogorek kamilogorek deleted the gettransport-guard branch September 27, 2021 12:51
@smeubank smeubank added this to the Client Reports milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sentry/react - Uncaught TypeError: _a.getTransport is not a function
3 participants