Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): Use getGlobalObject for document check #3996

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

AbhiPrasad
Copy link
Member

This should fix possible web worker issues here

Supercedes #3994

We should really refactor getGlobalObject usage so it's only called once tbh - could be a simple bundle size save.

This should fix possible web worker issues
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.24 KB (0%)
@sentry/browser - Webpack 23.23 KB (0%)
@sentry/react - Webpack 23.26 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.68 KB (0%)

@kamilogorek kamilogorek merged commit ba50656 into master Sep 21, 2021
@kamilogorek kamilogorek deleted the abhi-global-check-outcome branch September 21, 2021 07:46
@smeubank smeubank added this to the Client Reports milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants