fix(nextjs): Differentiate between webpack 4 and 5 in server builds #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-nextjs-no-server-chunks-under-webpack-4
branch
from
bad9217 to
5e608d2
Compare
size-limit report
|
AbhiPrasad
approved these changes
Aug 6, 2021
|
|
||
| const isWebpack5 = webpack.version.startsWith('5'); |
There was a problem hiding this comment.
I wonder if we an use the webpack 5 check to simplify the logic on how we add entry points with addFileToExistingEntryPoint (instead of having the various if else conditions)
There was a problem hiding this comment.
It's not a bad idea, but once I sat down to try to do it, I realized that though knowing it's webpack 4 would narrow down the possible formats, knowing it's webpack 5 wouldn't, because it can take all of the webpack 4 formats along with its own new formats. So just because of webpack 5 I think we need all the if/elses. Unless you're seeing something I'm not?
In any case, I'm going to merge this and we can handle that, if we do, in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to cut down on the number of unnecessary files which get uploaded by the Sentry webpack plugin during nextjs builds, we're quite specific about which filepaths to scan. The change which introduced that specificity missed the fact that under webpack 4,
.next/server/chunksis not generated. This leads the Sentry webpack plugin to throw an error when it tries to upload it, even though nothing is actually amiss.This PR fixes that, by checking the webpack version before deciding which files to upload with the plugin.