Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): Do not start a navigation if from url is the same #3814

Merged
merged 1 commit into from
Jul 16, 2021
Merged

fix(nextjs): Do not start a navigation if from url is the same #3814

merged 1 commit into from
Jul 16, 2021

Commits on Jul 16, 2021

  1. fix(nextjs): Do not start a navigation if from url is the same 

    Right now in certain cases (like with SSR), the router change state
triggers twice for a single pageload. This means that a pageload will
end early and start a transaction with the same name.

See logic: https://github.com/vercel/next.js/blob/e89b8e466aad110f8af3f60ef7d8292f6064a245/packages/next/client/index.tsx#L204

This patch adds a check to make sure that navigation transactions are
only created if the route URL is different.
    @AbhiPrasad
    AbhiPrasad committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    dff278b View commit details
    Browse the repository at this point in the history