Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-vitals): Upgrade to web-vitals v1.1.2 #3546

Closed
wants to merge 5 commits into from

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented May 14, 2021

🚧 WIP 🏗️

Bumps web-vitals to v1.1.2. I'm pretty sure I'm closing this one in favour of a PR with cleaner README + commits, but wanted to get this one out so y'all can spend your weekend thinking about vitals :)))

These are scary changes so there is still a lot to do before we can make this ready to review. Also my first time touching this stuff so apologies if I'm missing something here.

  • Port over the web-vitals tests. Def write some tests myself also
  • Do some extensive testing on Sentry instance with multiple browsers
  • Figure out if the bug fixes/breaking changes may result in large changes/discrepencies and how we can communicate that (either docs or heads up to support)
  • Figure out the polyfill stuff (need some help with that)
  • Figure out if we wanna support onBFCacheRestore: https://web.dev/bfcache/.

For more reference for the last 2, see: GoogleChrome/web-vitals#87

Also I might end up closing this PR and doing this upgrade later as v2 is pretty close to come out (and we can just bite the bullet that way).

@AbhiPrasad AbhiPrasad self-assigned this May 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 20.97 KB (-0.01% 🔽)
@sentry/browser - Webpack 21.84 KB (0%)
@sentry/react - Webpack 21.88 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.59 KB (+0.83% 🔺)

@AbhiPrasad
Copy link
Member Author

@AbhiPrasad AbhiPrasad closed this Jul 7, 2021
@AbhiPrasad AbhiPrasad deleted the abhi/web-vitals branch July 7, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant