build(eslint): Create eslint-config-sentry-sdks #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
changed the title
kamilogorek
force-pushed
the
abhi/global-eslint
branch
from
b93363c to
c5c7a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on #2806 merging in.
The original plan was to create a package under the
eslint-config-sentryrepo.I thought it best to let it live hear because a) if we change any rules or add any plugins, we can immediately see the impact, and b) this is synced with our releases, which means it'll sync up with our other general upgrades (typescript/prettier etc.).Other people already consume
@sentry/typescript, so I thought it was fine for it to live here.Right now the package is published as
eslint-config-sentry-sdksandeslint-plugin-sentry-sdksbut I am also open to calling it@sentry/eslint-configand@sentry/eslint-plugin. I didn't opt to use the scoped package because I thought the regular package name fit better, but I'm open for change.WIth this merged, we can cut a a release and then consume the package from the other SDKs.