Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(apm): Remove status from tags in transaction #2497

Merged
merged 1 commit into from
Mar 16, 2020
Merged

ref(apm): Remove status from tags in transaction #2497

merged 1 commit into from
Mar 16, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Mar 13, 2020

This is the JS implementation for this Python PR
getsentry/sentry-python#644

@HazAT HazAT requested a review from kamilogorek as a code owner March 13, 2020 15:02
@HazAT HazAT requested review from markstory and untitaker March 13, 2020 15:02
@HazAT HazAT changed the title ref: Remove status from tags in transaction ref(apm): Remove status from tags in transaction Mar 13, 2020
@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES6: 15.9248 kB) (ES5: 16.8838 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 03f751f

markstory
markstory approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HazAT HazAT merged commit 49142c1 into master Mar 16, 2020
@HazAT HazAT deleted the apm/no-status-in-tags branch March 16, 2020 09:05
This was referenced Mar 23, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 12, 2020
Closed
Merged
Merged
Closed
Merged
Merged
This was referenced Apr 20, 2020
Open
Closed
Closed
This was referenced Apr 28, 2020
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstory markstory markstory approved these changes

@untitaker untitaker untitaker approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HazAT @getsentry-bot @markstory @untitaker