ref(core): Move log message about invalid sample rate #15215
Merged
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Jan 29, 2025
| @@ -41,7 +41,12 @@ export function sampleSpan( | |||
| const parsedSampleRate = parseSampleRate(sampleRate); | |||
|
|
|||
| if (parsedSampleRate === undefined) { | |||
| DEBUG_BUILD && logger.warn('[Tracing] Discarding transaction because of invalid sample rate.'); | |||
| DEBUG_BUILD && | |||
| logger.trace( | |||
There was a problem hiding this comment.
l: why use logger.trace here vs. logger.log or similar?
There was a problem hiding this comment.
whoops, I used trace to debug. Switching back... Thanks!
size-limit report 📦
|
Lms24
approved these changes
Jan 29, 2025
| @@ -20,7 +20,7 @@ export function hasTracingEnabled( | |||
| const options = maybeOptions || client?.getOptions(); | |||
| return ( | |||
| !!options && | |||
| // Note: This check is `!= null`, meaning "nullish" | |||
| // Note: This check is `!= null`, meaning "nullish". `0` is not "nullish", `undefined` and `null` are. (This comment was brought to you by 15 minutes of questioning life) | |||
Co-authored-by: Lukas Stracke <[email protected]>
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The location we logged a message about an invalid sample rate was way too central. Originally we only logged it in the sampler but nowadays it is used in a bunch of other places like replay or propagation logic where it makes no sense to log the message.