Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/v8): Add compatibility layer for Prisma v5 #15210

Open
wants to merge 6 commits into
base: v8
Choose a base branch
from
Open

fix(node/v8): Add compatibility layer for Prisma v5 #15210

wants to merge 6 commits into from
+342 −19

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 29, 2025

This is a slightly transformed backport of #15169 preventing Prisma v6 from crashing when we apply Prisma v5 Instrumentation

@lforst lforst requested review from mydea and AbhiPrasad January 29, 2025 09:09
@lforst lforst marked this pull request as ready for review January 29, 2025 09:09
mydea
mydea approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it is the same as the v9 one (more or less), so 👍

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
700 1 699 302
View the top 1 failed tests by shortest run time 
tracing/metrics/web-vitals/test.ts captures time origin and navigation activationStart as span attributes
Stack Traces | 30s run time 
test.ts:62:11 captures time origin and navigation activationStart as span attributes

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @mydea