Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs): Add fastify support #14549

Merged
merged 10 commits into from
Dec 5, 2024
Merged

feat(nestjs): Add fastify support #14549

merged 10 commits into from
Dec 5, 2024

Conversation

chargome
Copy link
Member

@chargome chargome commented Dec 3, 2024

  • Adapts setting the transaction name to the fastify request object
  • Adds a nestjs e2e test:
    • fastify adapter was added
    • ts was bumped to v5 because fastify types are not compatible with v4
    • express request and response types have been replaced
    • expected spans have been updated

closes #14548

@chargome chargome self-assigned this Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
661 1 660 27
View the full list of 1 ❄️ flaky tests
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes

Flake rate in main: 78.95% (Passed 4 times, Failed 15 times)

Stack Traces | 30s run time
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@chargome chargome changed the title test(nestjs): Add fastify e2e test feat(nestjs): Add fastify support Dec 3, 2024
packages/nestjs/src/setup.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.19 KB - -
@sentry/browser - with treeshaking flags 21.87 KB - -
@sentry/browser (incl. Tracing) 35.69 KB - -
@sentry/browser (incl. Tracing, Replay) 72.59 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.02 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.9 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.39 KB - -
@sentry/browser (incl. Feedback) 39.95 KB - -
@sentry/browser (incl. sendFeedback) 27.8 KB - -
@sentry/browser (incl. FeedbackAsync) 32.59 KB - -
@sentry/react 25.87 KB - -
@sentry/react (incl. Tracing) 38.5 KB - -
@sentry/vue 27.4 KB - -
@sentry/vue (incl. Tracing) 37.51 KB - -
@sentry/svelte 23.35 KB - -
CDN Bundle 24.36 KB - -
CDN Bundle (incl. Tracing) 37.34 KB - -
CDN Bundle (incl. Tracing, Replay) 72.21 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.55 KB - -
CDN Bundle - uncompressed 71.6 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.88 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.95 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 237.17 KB - -
@sentry/nextjs (client) 38.79 KB - -
@sentry/sveltekit (client) 36.17 KB - -
@sentry/node 152.11 KB - -
@sentry/node - without tracing 98.99 KB -0.01% -2 B 🔽
@sentry/aws-serverless 144.01 KB -0.01% -1 B 🔽

View base workflow run

@chargome chargome requested review from mydea and AbhiPrasad December 4, 2024 12:17
packages/node/src/index.ts Outdated Show resolved Hide resolved
@chargome chargome merged commit 1c72b31 into develop Dec 5, 2024
154 checks passed
@chargome chargome deleted the cg/nest-fastify-e2e branch December 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support fastify in NestJS
4 participants