feat(opentelemetry): Update OpenTelemetry dependencies to 1.28.0
#14547
Conversation
mydea
changed the title
1.28.01.28.0
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| @@ -33,6 +33,7 @@ test('Lambda layer SDK bundle sends events', async ({ request }) => { | |||
| 'sentry.op': 'function.aws.lambda', | |||
| 'cloud.account.id': '123453789012', | |||
| 'faas.id': 'arn:aws:lambda:us-east-1:123453789012:function:my-lambda', | |||
| 'faas.coldstart': true, | |||
There was a problem hiding this comment.
nice new attribute from the otel instrumentation!
There was a problem hiding this comment.
| @@ -28,18 +28,22 @@ test('AWS Serverless SDK sends events in ESM mode', async ({ request }) => { | |||
| expect(transactionEvent.contexts?.trace).toEqual({ | |||
| data: { | |||
| 'sentry.sample_rate': 1, | |||
| 'sentry.source': 'component', | |||
| 'sentry.origin': 'auto.function.serverless', | |||
| 'sentry.source': 'custom', | |||
There was a problem hiding this comment.
this now uses the proper OTEL instrumentation here! 🚀
| @@ -54,6 +58,19 @@ test('AWS Serverless SDK sends events in ESM mode', async ({ request }) => { | |||
| }), | |||
| ); | |||
|
|
|||
| expect(transactionEvent.spans).toContainEqual( | |||
There was a problem hiding this comment.
apparently our check isWrappedByOtel is not working, so we still emit the span. it's not really a problem as this will just be a child, but weird...
| @@ -10,6 +10,7 @@ module.exports = { | |||
| testMatch: ['<rootDir>/**/*.test.ts', '<rootDir>/**/*.test.tsx'], | |||
| moduleNameMapper: { | |||
| '^axios$': require.resolve('axios'), | |||
| '@opentelemetry/semantic-conventions/incubating': require.resolve('@opentelemetry/semantic-conventions/incubating'), | |||
There was a problem hiding this comment.
this is needed to make this work with jest 😬
|
Bundle size is increasing quite a bit 😬 but not sure what we can do about that. |
There was a problem hiding this comment.
Is there a particular reason we are vendoring this? I would add a comment why and if we did any changes we also need to note them down.
There was a problem hiding this comment.
ah sorry, forgot to mention - they removed the export 😬
There was a problem hiding this comment.
so no changes, just 1-1 copied this in!
| @@ -33,6 +33,7 @@ test('Lambda layer SDK bundle sends events', async ({ request }) => { | |||
| 'sentry.op': 'function.aws.lambda', | |||
| 'cloud.account.id': '123453789012', | |||
| 'faas.id': 'arn:aws:lambda:us-east-1:123453789012:function:my-lambda', | |||
| 'faas.coldstart': true, | |||
There was a problem hiding this comment.
mydea
force-pushed
the
fn/bump-otel-deps
branch
from
6e22897 to
ac49e8b
Compare
mydea
force-pushed
the
fn/bump-otel-deps
branch
from
ac49e8b to
bf29fb3
Compare
Updates all OpenTelemetry dependencies to 1.28.0, as well as all instrumentation except for prisma (which is a major from 5 to 6, so leaving this out for now...) to their latest version.