Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxt): Add filter for not found source maps (devtools) #14437

Merged
merged 4 commits into from
Nov 22, 2024
Merged

feat(nuxt): Add filter for not found source maps (devtools) #14437

merged 4 commits into from
Nov 22, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Nov 22, 2024

Dev tools sometimes try to access source maps. This filter makes sure this error is not reported in Sentry as it adds noise to the data.

@s1gr1d s1gr1d requested a review from Lms24 November 22, 2024 19:45
@s1gr1d s1gr1d self-assigned this Nov 22, 2024
Lms24
Lms24 reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test for this. e2e might be difficult but maybe we can add a unit test with an event payload we saw earlier today?

@s1gr1d s1gr1d requested a review from Lms24 November 22, 2024 20:51
Lms24
Lms24 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

@s1gr1d s1gr1d merged commit 05479b8 into develop Nov 22, 2024
35 checks passed
@s1gr1d s1gr1d deleted the sig/source-maps-filter branch November 22, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

@s1gr1d s1gr1d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s1gr1d @Lms24