fix(core): Ensure standalone spans are not sent if SDK is disabled #14088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Oct 28, 2024
| @@ -565,7 +565,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> { | |||
|
|
|||
| if (this._isEnabled() && this._transport) { | |||
| return this._transport.send(envelope).then(null, reason => { | |||
| DEBUG_BUILD && logger.error('Error while sending event:', reason); | |||
| DEBUG_BUILD && logger.error('Error while sending envelope:', reason); | |||
There was a problem hiding this comment.
Given that sendEnvelope is called for multiple envelope item types (not just events), I opted to slightly change the message here to reflect this
chargome
approved these changes
Oct 28, 2024
size-limit report 📦
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when standalone (most prominently INP) spans would
.end(), they'd always be sent to Sentry, even if the SDK was disabled (viaSentry.init({enabled: false})for example). This was caused by us directly callingtransport.sendand not checking for the enabled option, instead of using the client to send the span envelope.This PR now changes the sending logic to use the client's
sendEnvelopemethod which we generally use to send envelopes (sessions, client reports, checkins, metrics (RIP), and also events). This has a minor implication: We will now also emit abeforeEnvelopeclient hook event for sending standalone spans. I think this is actually more correct than before but could potentially break someone. IMO this is worth the "risk" as it's easily revertible and client hooks are primarily meant for internal use. Happy to adjust the PR though if reviewers have different opinions.fixes #14082